[6.x] Fix field filters returning all results when filtering by 0#14747
Merged
Conversation
The zero value bug isn't realistically triggerable in these classes (date, terms, and toggle don't accept 0 as a meaningful filter value), but they override isComplete() with the same array_filter pattern so the fix is applied for consistency. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jasonvarga
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On listing views filtering a field using
0as the value returns items as no filter was being used instead of matching ones with an actual value of0.Example: A text or integer field like
Levelscontaining values like0,1,2,3, filtering for0ignores the filter entirely and returns all entries.Statamic\Query\Scopes\Filters\Fields\FieldtypeFilter::isComplete()does$values = array_filter($values)wherearray_filter()with no callback removes every falsy element including both the string'0'and integer0. With the value stripped,isComplete()returnsfalseand never applies the filter.The fix is to replace
array_filter()with explicit checks, so 0 and '0' are treated as actual values while actual empty filters (null,'') are skipped.Related:
nullor0fortitleorslugcauses issues #137850values in text fields andnullstring in slugs #13786